From a2c64a4810df6d70ec65a1fc773a5175a298788d Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Sat, 7 Mar 2015 16:15:01 +1100 Subject: [PATCH] ctdb-common: Reimplement external tracing using ctdb_set_helper() Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs --- ctdb/common/ctdb_util.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ctdb/common/ctdb_util.c b/ctdb/common/ctdb_util.c index 8e2e430da71..5d63c272926 100644 --- a/ctdb/common/ctdb_util.c +++ b/ctdb/common/ctdb_util.c @@ -134,14 +134,16 @@ bool ctdb_set_helper(const char *type, char *helper, size_t size, void ctdb_external_trace(void) { int ret; - const char * t = getenv("CTDB_EXTERNAL_TRACE"); + static char external_trace[PATH_MAX+1] = ""; char * cmd; - if (t == NULL) { + if (!ctdb_set_helper("external trace handler", + external_trace, sizeof(external_trace), + "CTDB_EXTERNAL_TRACE", NULL, NULL)) { return; } - cmd = talloc_asprintf(NULL, "%s %lu", t, (unsigned long) getpid()); + cmd = talloc_asprintf(NULL, "%s %lu", external_trace, (unsigned long) getpid()); DEBUG(DEBUG_WARNING,("begin external trace: %s\n", cmd)); ret = system(cmd); if (ret == -1) { -- 2.11.4.GIT