From 97f1514ce95800f1296b1979f1b34dcc5d56a376 Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Tue, 10 Feb 2009 10:59:34 +0100 Subject: [PATCH] s3-spoolss: fix memleak in get_remote_printer_publishing_data(). Guenther --- source/libads/ldap_printer.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/source/libads/ldap_printer.c b/source/libads/ldap_printer.c index eb6e3d3b100..3ff88466dd5 100644 --- a/source/libads/ldap_printer.c +++ b/source/libads/ldap_printer.c @@ -328,11 +328,14 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, if (!W_ERROR_IS_OK(result)) { DEBUG(3, ("Unable to open printer %s, error is %s.\n", printername, dos_errstr(result))); + SAFE_FREE(printername); return result; } - if ( !(dsdriver_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) + if ( !(dsdriver_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) { + SAFE_FREE(printername); return WERR_NOMEM; + } result = rpccli_spoolss_enumprinterdataex(cli, mem_ctx, &pol, SPOOL_DSDRIVER_KEY, dsdriver_ctr); @@ -348,8 +351,10 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, } } - if ( !(dsspooler_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) + if ( !(dsspooler_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) { + SAFE_FREE(printername); return WERR_NOMEM; + } result = rpccli_spoolss_enumprinterdataex(cli, mem_ctx, &pol, SPOOL_DSSPOOLER_KEY, dsspooler_ctr); @@ -370,6 +375,7 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, TALLOC_FREE( dsspooler_ctr ); rpccli_spoolss_close_printer(cli, mem_ctx, &pol); + SAFE_FREE(printername); return result; } -- 2.11.4.GIT