From 80d9663b3635ed7b2e9b3308d27aed08cd1f38fb Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 18 Feb 2010 12:21:10 -0800 Subject: [PATCH] Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash" The charset array allocated in init_chartest() is allocated by MALLOC, but only some elements of it being set after allocation. Fix is to memset to zero after allocation. Jeremy. (cherry picked from commit a4e8210ba7d6d471cb9f17754244393b9c1e5930) --- source/smbd/mangle_hash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source/smbd/mangle_hash.c b/source/smbd/mangle_hash.c index 7073c3c64eb..e081a57484a 100644 --- a/source/smbd/mangle_hash.c +++ b/source/smbd/mangle_hash.c @@ -335,6 +335,7 @@ static void init_chartest( void ) chartest = SMB_MALLOC_ARRAY(unsigned char, 256); SMB_ASSERT(chartest != NULL); + memset(chartest, '\0', 256); for( s = (const unsigned char *)basechars; *s; s++ ) { chartest[*s] |= BASECHAR_MASK; -- 2.11.4.GIT