From 7d90c1b0c857614ea6be2685d1f62fa5a7de810f Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 29 Apr 2014 16:59:55 -0700 Subject: [PATCH] s3: smbd : Fix wildcard unlink to fail if we get an error rather than trying to continue. This can break smbd if we end up leaving a SHARING_VIOLATION retry record on the queue. Signed-off-by: Jeremy Allison Fix bug #10577 - SMB1 wildcard unlink fail can leave a retry record on the open retry queue. --- source3/smbd/reply.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index 902b43f6d69..8b16a0c79c2 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -2916,9 +2916,10 @@ NTSTATUS unlink_internals(connection_struct *conn, struct smb_request *req, status = do_unlink(conn, req, smb_fname, dirtype); if (!NT_STATUS_IS_OK(status)) { + TALLOC_FREE(dir_hnd); TALLOC_FREE(frame); TALLOC_FREE(talloced); - continue; + goto out; } count++; -- 2.11.4.GIT