From 53e8d527f3e2d9ff0173263531105d29e7eabb20 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 17 Aug 2015 21:12:56 +0200 Subject: [PATCH] param: Use talloc_pooled_object Reduce memory fragmentation a bit and obsolete NULL checks Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Fri Aug 21 14:45:58 CEST 2015 on sn-devel-104 --- lib/param/loadparm.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c index c62e0dee911..a0700a96f02 100644 --- a/lib/param/loadparm.c +++ b/lib/param/loadparm.c @@ -824,20 +824,14 @@ void set_param_opt(TALLOC_CTX *mem_ctx, opt = opt->next; } - new_opt = talloc(mem_ctx, struct parmlist_entry); + new_opt = talloc_pooled_object( + mem_ctx, struct parmlist_entry, + 2, strlen(opt_name) + 1 + strlen(opt_value) + 1); if (new_opt == NULL) { smb_panic("OOM"); } - new_opt->key = talloc_strdup(new_opt, opt_name); - if (new_opt->key == NULL) { - smb_panic("talloc_strdup failed"); - } - new_opt->value = talloc_strdup(new_opt, opt_value); - if (new_opt->value == NULL) { - smb_panic("talloc_strdup failed"); - } new_opt->list = NULL; new_opt->priority = priority; -- 2.11.4.GIT