From 20417945fed17a8f6ca2b0fc66c20890dc1f48b8 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 8 Mar 2016 13:46:16 +1300 Subject: [PATCH] pytalloc: Correct description of pytalloc_Get{Base,}ObjectType behaviour Thanks to Jelmer for spotting the static variable that causes this odd behaviour Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Mar 8 05:14:15 CET 2016 on sn-devel-144 --- lib/talloc/pytalloc_guide.txt | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/talloc/pytalloc_guide.txt b/lib/talloc/pytalloc_guide.txt index 8e9694e0177..1aa4f994479 100644 --- a/lib/talloc/pytalloc_guide.txt +++ b/lib/talloc/pytalloc_guide.txt @@ -60,16 +60,18 @@ in the way needed by PIDL. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- PyTypeObject *pytalloc_GetObjectType(void) -Obtain a reference to the PyTypeObject for `pytalloc_Object`. The reference -counter for the object will be incremented, so the caller will have to -decrement it when it no longer needs it (using `Py_DECREF`). +Obtain a pointer to the PyTypeObject for `pytalloc_Object`. The +reference counter for the object will be NOT incremented, so the +caller MUST NOT decrement it when it no longer needs it (eg by using +`Py_DECREF`). =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- PyTypeObject *pytalloc_GetBaseObjectType(void) -Obtain a reference to the PyTypeObject for `pytalloc_Object`. The reference -counter for the object will be incremented, so the caller will have to -decrement it when it no longer needs it (using `Py_DECREF`). +Obtain a pointer to the PyTypeObject for `pytalloc_BaseObject`. The +reference counter for the object will be NOT incremented, so the +caller MUST NOT decrement it when it no longer needs it (eg by using +`Py_DECREF`). =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- int pytalloc_BaseObject_PyType_Ready(PyTypeObject *type); -- 2.11.4.GIT