From 01d4c0e804e0c10fe6acfbdbe6747dcc5df6abc9 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 2 Sep 2014 14:38:11 +1200 Subject: [PATCH] torture: Provide enough space for test EA name in raw.eas test The issue is that previously bad_ea_name[5] was the last element on the array, and so when we later did a strlen() on it, we read past the end of the stack array. We need bad_ea_name[5] to be the second-last element, followed by the \0 placed there by the strlcpy(). Found by AddressSanitizer Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88 Signed-off-by: Andrew Bartlett Reviewed-by: Kamen Mazdrashki Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Thu Sep 11 08:50:16 CEST 2014 on sn-devel-104 --- source4/torture/raw/eas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/torture/raw/eas.c b/source4/torture/raw/eas.c index 95a55d1ecf5..15bfb2f072e 100644 --- a/source4/torture/raw/eas.c +++ b/source4/torture/raw/eas.c @@ -51,7 +51,7 @@ static bool test_eas(struct smbcli_state *cli, struct torture_context *tctx) union smb_open io; const char *fname = BASEDIR "\\ea.txt"; bool ret = true; - char bad_ea_name[6]; + char bad_ea_name[7]; int i; int fnum = -1; -- 2.11.4.GIT