ldb: Log the partition we're repacking
commitee6537c29e747206ee607493ce15d4532fb670c8
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 30 Jul 2019 22:33:49 +0000 (31 10:33 +1200)
committerGarming Sam <garming@samba.org>
Tue, 20 Aug 2019 03:40:29 +0000 (20 03:40 +0000)
treeb7726af68c619226013a0d1d0afe67587c37d12d
parent5fee9388422e259c2a56e4dccbf44d22ba426ca3
ldb: Log the partition we're repacking

Firstly, with Samba AD this looks a little weird because we log the same
message 5 times (once for every partition). If we log that we're doing
this to records in different partitions, hopefully someone with a little
Samba knowledge can figure out what's going on.

Secondly, the info about what partitions are actually changing might be
useful. E.g. if we hit a fatal error repacking the 3rd partition, and
the transaction doesn't abort properly, then it would be useful to know
what partitions were repacked and which ones weren't.

There doesn't appear to be a useful name for the partition
(ldb_kv->kv_ops->name() doesn't seem any more intelligible to a user),
so just log the first record that we update. We can use that to infer
the partition database).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
lib/ldb/ldb_key_value/ldb_kv_index.c