s4:kdc: only map SDB_ERR_NOT_FOUND_HERE to HDB_ERR_NOT_FOUND_HERE
commitaaa946bb9eb8088389b8ffdec460023f1961616c
authorStefan Metzmacher <metze@samba.org>
Thu, 21 Sep 2017 10:02:25 +0000 (21 12:02 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 6 Dec 2017 22:16:54 +0000 (6 23:16 +0100)
tree7cc7dd80560657863840e5681297b3cf79bf336f
parent183e5d1e3dc306491c06f94c8c98e4882c64bc27
s4:kdc: only map SDB_ERR_NOT_FOUND_HERE to HDB_ERR_NOT_FOUND_HERE

HDB_ERR_NOT_FOUND_HERE indicated a very specific error on an RODC.

We should not map any error to HDB_ERR_NOT_FOUND_HERE,
we should just pass errors along unmapped.

Otherwise we'll hit the logic bug in:

    if (ret == KDC_PROXY_REQUEST) {
        uint16_t port;

        if (!sock->kdc_socket->kdc->am_rodc) {
            DEBUG(0,("kdc_udp_call_loop: proxying requested when not RODC"));
                    talloc_free(call);
            goto done;
        }

And just don't send an error message to the client.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13132

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec  6 23:16:54 CET 2017 on sn-devel-144
source4/kdc/hdb-samba4.c