| commit | 9198246f91c02e33ed7a3580588557d0fb9f8811 | |
| author | Steve Howells <steve.howells@moscowfirst.com> | |
| Sat, 31 Jan 2015 16:09:17 +0000 (31 16:09 +0000) | ||
| committer | Andrew Bartlett <abartlet@samba.org> | |
| Mon, 16 Mar 2015 02:00:06 +0000 (16 03:00 +0100) | ||
| tree | 02d6128748bef1bde7cd59167bc9c5ddf033e785 | treesnapshot (tar.gz zip) |
| parent | 09b3e42e70b35bfa1985e70780a67085644b9914 | commitdiff |
s4.2/fsmo.py: fixed fsmo transfer exception
In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
where the type of role is being determined (specifically for the naming fsmo). This
call is unnecessary as after the if statement their is a correct call, with a try/catch
block, used by all fsmo transfers that will handle errors - such as the DC with the
fsmo role being offline.
The call to samdb.modify() inside the if statement for naming fsmo has been removed.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924
Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
where the type of role is being determined (specifically for the naming fsmo). This
call is unnecessary as after the if statement their is a correct call, with a try/catch
block, used by all fsmo transfers that will handle errors - such as the DC with the
fsmo role being offline.
The call to samdb.modify() inside the if statement for naming fsmo has been removed.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924
Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| python/samba/netcmd/fsmo.py | diffblobblamehistory |