s3: smbd: Tweak openat_pathref_dirfsp_nosymlink() to NULL out fsp->fsp_name after...
commit3d3d01cda8d3a6d0d18d1b808aa9414e71d56062
authorJeremy Allison <jra@samba.org>
Thu, 12 Jan 2023 19:20:08 +0000 (12 11:20 -0800)
committerVolker Lendecke <vl@samba.org>
Fri, 13 Jan 2023 08:33:47 +0000 (13 08:33 +0000)
tree060fd66ee06dc3484c454a501e67ea3d1f365c60
parentc844bff3eca336547c6cedfeeb03adda4eed57c6
s3: smbd: Tweak openat_pathref_dirfsp_nosymlink() to NULL out fsp->fsp_name after calling fd_close() on intermediate directories, rather than before.

vfs_virusfilter expects a non-NULL fsp->fsp_name to use for printing debugs
(it always indirects fsp->fsp_name). vfs_fruit also does the same, so would
also crash in fruit_close() with 'debug level = 10' and vfs_default:VFS_OPEN_HOW_RESOLVE_NO_SYMLINKS = no
set (we don't test with that which is why we haven't noticed
this before).

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15283

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jan 13 08:33:47 UTC 2023 on sn-devel-184
selftest/knownfail.d/virusscanner [deleted file]
source3/smbd/files.c