| commit | 31e67507144aae8d5a8ec49587ac89d2d94636f0 | |
| author | Michael Adam <obnox@samba.org> | |
| Thu, 3 Jul 2014 08:10:11 +0000 (3 10:10 +0200) | ||
| committer | Christof Schmitt <cs@samba.org> | |
| Sun, 13 Jul 2014 06:59:11 +0000 (13 08:59 +0200) | ||
| tree | 2a14917de579bb502e469a12848e9192ced579f8 | treesnapshot (tar.gz zip) |
| parent | 573ca6ef6b8376800d8fc988d67909e103b74656 | commitdiff |
s3:vfs:gpfs: fix flapping offline: always get winAttrs from gpfs for is_offline
There is a problem of flapping offline due to uninitialized
stat buffers. Due to a optimization in vfswrap_readdir which
directly calling fastatat (i.e. not through vfs), marking the
stat buffer valid, there is nothing this module can do about
it and hence can not currently not rely on the vaildity of
the stat buffer.
By always calling out to GPFS even when the stat buffer is
flagged valid, we can always return correct offline information,
thereby sacrificing the readdir optimization.
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
There is a problem of flapping offline due to uninitialized
stat buffers. Due to a optimization in vfswrap_readdir which
directly calling fastatat (i.e. not through vfs), marking the
stat buffer valid, there is nothing this module can do about
it and hence can not currently not rely on the vaildity of
the stat buffer.
By always calling out to GPFS even when the stat buffer is
flagged valid, we can always return correct offline information,
thereby sacrificing the readdir optimization.
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
| source3/modules/vfs_gpfs.c | diffblobblamehistory |