ctdb-recoverd: Flatten update_flags_on_all_nodes()
commit0c6a7db3ba84b8355359b0a8c52690b234bb866d
authorMartin Schwenke <martin@meltin.net>
Fri, 28 Sep 2018 00:46:17 +0000 (28 10:46 +1000)
committerMartin Schwenke <martins@samba.org>
Fri, 24 Jul 2020 04:41:25 +0000 (24 04:41 +0000)
tree1b5927cbb5732e68cd0460e426a4971ca230081c
parenta88c10c5a9afcf0a3dcadef07dd95af498bfa47a
ctdb-recoverd: Flatten update_flags_on_all_nodes()

The logic currently in ctdb_ctrl_modflags() will be optimised so that
it no longer matches the pattern for a control function.  So, remove
this function and squash its functionality into the only caller.

Although there are some superficial changes, the behaviour is
unchanged.

Flattening the 2 functions produces some seriously weird logic for
setting the new flags, to the point where using ctdb_ctrl_modflags()
for this purpose now looks very strange.  The weirdness will be
cleaned up in a subsequent commit.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/server/ctdb_recoverd.c