Revert "reduce symbol visibility in sw"
commitf4d15c1cf34f8dac870c2771d6317a56b3fdf038
authorThorsten Behrens <thorsten.behrens@allotropia.de>
Fri, 26 Apr 2024 07:05:38 +0000 (26 09:05 +0200)
committerThorsten Behrens <thorsten.behrens@allotropia.de>
Mon, 13 May 2024 06:17:31 +0000 (13 08:17 +0200)
treea464e7d9047e39a0c049e5d3c331b36201517ed8
parent737a07897e7414228d727fd3d16b3bd47ff226fa
Revert "reduce symbol visibility in sw"

This reverts commit 1a6711276f0c8abeb0028a47cc345a7453374a38.

After some discussion and experiments, it turned out this rather
fundamentally breaks clang's PCH build. Conclusion was: this change is
not significant enough to warrant making life harder for developers.

Excerpt of errors (affected were vbaswobj, msword & swui libs):

- ld.lld: error: undefined symbol: SwFormat::~SwFormat()
  >>> referenced by fmtcol.hxx:37 (sw/inc/fmtcol.hxx:37)
  >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_vbaswobj.o:(SwFormatColl::~SwFormatColl())
- ld.lld: error: undefined symbol: SwFrameFormat::SetPositionLayoutDir(short)
  >>> referenced by precompiled_msword.cxx
  >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_msword.o:(vtable for sw::SpzFrameFormat)
- ld.lld: error: undefined symbol: SwFrameFormat::SetLayoutDir(SwFrameFormat::tLayoutDir)
  >>> referenced by precompiled_swui.cxx
  >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_swui.o:(vtable for sw::SpzFrameFormat)

Change-Id: I1dcf115cc191b1ebf1f8d5023c0c5015f891287a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167549
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
40 files changed:
sw/inc/authfld.hxx
sw/inc/docsh.hxx
sw/inc/docstyle.hxx
sw/inc/docufld.hxx
sw/inc/expfld.hxx
sw/inc/fmtcol.hxx
sw/inc/fmtfld.hxx
sw/inc/format.hxx
sw/inc/formatcontentcontrol.hxx
sw/inc/frmfmt.hxx
sw/inc/ndole.hxx
sw/inc/ndtxt.hxx
sw/inc/node.hxx
sw/inc/section.hxx
sw/inc/swtable.hxx
sw/inc/tblafmt.hxx
sw/inc/textboxhelper.hxx
sw/inc/txtftn.hxx
sw/inc/unotbl.hxx
sw/inc/unotextrange.hxx
sw/inc/unotxdoc.hxx
sw/inc/view.hxx
sw/inc/viscrs.hxx
sw/qa/core/layout/ftnfrm.cxx
sw/qa/core/txtnode/txtnode.cxx
sw/qa/uibase/shells/shells.cxx
sw/qa/uibase/shells/textsh.cxx
sw/source/core/inc/cellfrm.hxx
sw/source/core/inc/cntfrm.hxx
sw/source/core/inc/dflyobj.hxx
sw/source/core/inc/flyfrms.hxx
sw/source/core/inc/pagefrm.hxx
sw/source/core/inc/tabfrm.hxx
sw/source/core/inc/txtfrm.hxx
sw/source/filter/inc/wrtswtbl.hxx
sw/source/uibase/inc/basesh.hxx
sw/source/uibase/inc/mailmergehelper.hxx
sw/source/uibase/inc/pview.hxx
sw/source/uibase/inc/textsh.hxx
sw/source/uibase/uiview/view.cxx