From 293ca03ba7fc4ab7677c544d8179b443ff639671 Mon Sep 17 00:00:00 2001
From: Kouzinopoulos Charis <ckouz@uom.gr>
Date: Mon, 11 Feb 2008 10:26:15 +0200
Subject: [PATCH] Bugfix: Fixed crash in create_files(), fixed potential
 overflowing problems by substituting int with unsigned int, fixed indentation

---
 helper.c | 56 +++++++++++++++++++++++++++-----------------------------
 1 file changed, 27 insertions(+), 29 deletions(-)

diff --git a/helper.c b/helper.c
index 4c0d605..530071c 100644
--- a/helper.c
+++ b/helper.c
@@ -6,22 +6,22 @@
 /*Prints text and pattern*/
 void print_pattern( char **text, char **pattern, int m, int n )
 {
-	int i,j;
+	unsigned int i,j;
 
 	/*Prints the pattern*/
-	for(j = 0; j < m; j++) {
+	for( j = 0; j < m; j++ ) {
 
-		for(i = 0; i < m; i++)
+		for( i = 0; i < m; i++ )
 			printf("%i",pattern[j][i]);
 			
 		printf("\n");
 	}
 
 	/*Prints the text*/
-	for(j = 0; j < n; j++) {
+	for( j = 0; j < n; j++ ) {
 		printf("\n");
 
-		for(i = 0; i < n; i++)
+		for( i = 0; i < n; i++ )
 			printf("%c",text[j][i]);
 	}
 }
@@ -29,11 +29,9 @@ void print_pattern( char **text, char **pattern, int m, int n )
 /*Returns the square of a number*/
 int power(int number, int power)
 {
-	int i;
+	int i, returned_number = number;
 
-	int returned_number = number;
-
-	for(i=1;i<power;i++)
+	for( i = 1; i < power; i++ )
 		returned_number = returned_number * number;
 	
 	return returned_number;
@@ -44,7 +42,7 @@ void load_files( char **text, char **pattern, int m, int n )
 {
 	FILE *text_fp, *pattern_fp;
 	
-	int i,j;
+	unsigned int i,j;
 
 	int c;
 	
@@ -53,12 +51,12 @@ void load_files( char **text, char **pattern, int m, int n )
 	
 	for(j = 0; j < m; j++)
 		for(i = 0; i < m; i++) {
-			c = fgetc (pattern_fp);
+			c = fgetc( pattern_fp );
 			/* If we encounter '\n' pull the next character*/
-			if(c != 10)
+			if( c != 10 )
 				pattern[j][i] = c;
 			else
-				pattern[j][i] = fgetc (pattern_fp);
+				pattern[j][i] = fgetc( pattern_fp );
 		}
 		
 	fclose(pattern_fp);
@@ -66,14 +64,14 @@ void load_files( char **text, char **pattern, int m, int n )
 	/*Text loading*/
 	text_fp = fopen("data/text", "r");
 	
-	for(j = 0; j < n; j++)
-		for(i = 0; i < n; i++) {
+	for( j = 0; j < n; j++ )
+		for( i = 0; i < n; i++ ) {
 			c = fgetc (text_fp);
 			/* If we encounter '\n' pull the next character*/
-			if(c != 10)
+			if( c != 10 )
 				text[j][i] = c;
 			else
-				text[j][i] = fgetc (text_fp);
+				text[j][i] = fgetc( text_fp );
 		}
 	
 	fclose(text_fp);
@@ -84,31 +82,31 @@ void create_files(int pattern_size, int text_size, int alphabet)
 {
 	FILE *text_fp, *pattern_fp;
 	
-	int i,j;
+	unsigned int i,j;
 	
 	/* initialize random seed: */
-	srand( time(NULL) );
+	srand( time( NULL ) );
 	
 	/*Creating pattern*/
 	pattern_fp = fopen("data/pattern", "w");
 	
-	for(j = 0; j < pattern_size; j++){
-		for(i = 0; i < pattern_size; i++)
-			fputc (rand() % alphabet + 1, pattern_fp);
-		fputc (10, pattern_fp);
+	for( j = 0; j < pattern_size; j++ ) {
+		for( i = 0; i < pattern_size; i++ )
+			fputc( rand() % alphabet + 1, pattern_fp );
+		fputc( 10, pattern_fp );
 	}
 		
-	fclose(pattern_fp);
+	fclose( pattern_fp );
 
 	/*Creating text*/
 	text_fp = fopen("data/text", "w");
 	
-	for(j = 0; j < text_size; j++){
-		for(i = 0; i < text_size; i++)
-			fputc (rand() % alphabet + 1, pattern_fp);
-		fputc (10, pattern_fp);
+	for( j = 0; j < text_size; j++ ){
+		for( i = 0; i < text_size; i++ )
+			fputc ( rand() % alphabet + 1, text_fp );
+		fputc ( 10, text_fp );
 	}
 	
-	fclose(text_fp);
+	fclose( text_fp );
 }
 
-- 
2.11.4.GIT