| commit | 63c706b924ed0422b6816a72b8704bc3ed872792 | |
| author | Alexander Viro <viro@www.linux.org.uk> | |
| Mon, 4 Apr 2005 01:06:21 +0000 (3 18:06 -0700) | ||
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | |
| Mon, 4 Apr 2005 01:06:21 +0000 (3 18:06 -0700) | ||
| tree | eb0d534d138aef240fc3f3b423b82ab63d66f375 | treesnapshot (tar.gz zip) |
| parent | 376b07691ec54a44925b4fee024c089b8b7b6616 | commitdiff |
[PATCH] jsm fixes
a) jsm depends on PCI. Kconfig fixed.
b) spin_lock_irqsave() et.al. expect unsigned long, not u64.
c) pointer arithmetics works just fine without casts to u64, thank
you very much.
d) iomem annotations added.
e) jsm_get_mstat() lost bits - among other things it did
if (mstat & UART_MSR_DSR)
result |= TIOCM_DSR;
and ended with return result; since TIOCM_DSR is 256 on e.g. i386,
declaring result as unsigned char was a bad idea (function itself
returns int).
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
a) jsm depends on PCI. Kconfig fixed.
b) spin_lock_irqsave() et.al. expect unsigned long, not u64.
c) pointer arithmetics works just fine without casts to u64, thank
you very much.
d) iomem annotations added.
e) jsm_get_mstat() lost bits - among other things it did
if (mstat & UART_MSR_DSR)
result |= TIOCM_DSR;
and ended with return result; since TIOCM_DSR is 256 on e.g. i386,
declaring result as unsigned char was a bad idea (function itself
returns int).
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
| drivers/serial/Kconfig | diffblobblamehistory | |
| drivers/serial/jsm/jsm.h | diffblobblamehistory | |
| drivers/serial/jsm/jsm_neo.c | diffblobblamehistory | |
| drivers/serial/jsm/jsm_tty.c | diffblobblamehistory |