Improve interface to MakeType.open_shape
commitb58c45c8e1ceb693b939f7fc4fa1974c260954c5
authorScott Owens <sowens@meta.com>
Mon, 20 May 2024 14:11:42 +0000 (20 07:11 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 20 May 2024 14:11:42 +0000 (20 07:11 -0700)
tree923b6b31ecb42cf9802fe124f6c10bd4773530fb
parent75b182e04bab25bfe1398277ab3f13d35c50c4fe
Improve interface to MakeType.open_shape

Summary: Always using `mixed` as the type of `...` is dangerous since we might want to make open shapes with other types for `...`. Especially, `supportdyn<mixed>`.

Reviewed By: CatherineGasnier

Differential Revision: D57560149

fbshipit-source-id: 5efbe528d23b6e32c19ef0b6f46cfbcb573a7274
hphp/hack/src/typing/tast_check/global_access_check.ml
hphp/hack/src/typing/tast_check/readonly_check.ml
hphp/hack/src/typing/typing_make_type.ml
hphp/hack/src/typing/typing_shapes.ml