| commit | e89e36c01d09ca6aec03732e922e749257cac3f4 | |
| author | Dmitry Bogatov <KAction@disroot.org> | |
| Sun, 9 Feb 2020 05:47:09 +0000 (9 00:47 -0500) | ||
| committer | Ali Gholami Rudi <ali@rudi.ir> | |
| Tue, 18 Feb 2020 21:41:08 +0000 (19 01:11 +0330) | ||
| tree | ad64521384b3bbfef301334bb912700b58958a93 | treesnapshot (tar.gz zip) |
| parent | 1c1ed80097f2bb86ceab59699806fff2aa17d03f | commitdiff |
Avoid passing non-constant format string to printf
gcc complains loudly on any code that uses anything but string literal
as format string to printf. Right now format string is "const char *"
and does not contain %-sequences, but should '%' appear in "usage"
string in future, bad things would happen.
Since formatting functionality of "printf" is not used anyway, replacing
it with "puts" makes code both safer and easier to understand.
gcc complains loudly on any code that uses anything but string literal
as format string to printf. Right now format string is "const char *"
and does not contain %-sequences, but should '%' appear in "usage"
string in future, bad things would happen.
Since formatting functionality of "printf" is not used anyway, replacing
it with "puts" makes code both safer and easier to understand.
| fbpdf.c | diffblobblamehistory |