| commit | 4d924d484a06e8b463fff966297f87a1eabc21bd | |
| author | Maciej W. Rozycki <macro@embecosm.com> | |
| Tue, 12 Dec 2023 13:09:37 +0000 (12 13:09 +0000) | ||
| committer | Jacob Bachmeyer <jcb@gnu.org> | |
| Wed, 13 Dec 2023 02:45:58 +0000 (12 20:45 -0600) | ||
| tree | 6da8b1073a3df764ba0db2766ed6d55d8b51adcb | treesnapshot (tar.gz zip) |
| parent | 68464b73fdbb474fce995b68140293e4f6b2b61c | commitdiff |
Do not set `test_timeout' in `unix_load'
The `test_timeout' global parameter is expected to be optionally set by
a board description file and then taken into account by `unix_load' to
override the default of 300. However not only the procedure checks for
the override but it sets the global parameter to the default as well if
not present. This might make a minuscule TCL interpreter execution time
reduction, but seems rather awkward from the programming style's point
of view, and may cause undesired effects if the parameter is referred
elsewhere.
Remove the setting of the global parameter then, while retaining its
semantics.
* config/unix.exp (unix_load): Don't ever set `test_timeout',
just use it locally.
The `test_timeout' global parameter is expected to be optionally set by
a board description file and then taken into account by `unix_load' to
override the default of 300. However not only the procedure checks for
the override but it sets the global parameter to the default as well if
not present. This might make a minuscule TCL interpreter execution time
reduction, but seems rather awkward from the programming style's point
of view, and may cause undesired effects if the parameter is referred
elsewhere.
Remove the setting of the global parameter then, while retaining its
semantics.
* config/unix.exp (unix_load): Don't ever set `test_timeout',
just use it locally.
| config/unix.exp | diffblobblamehistory |