| commit | 2940006b5c653287a4261f3bc400f1b7b140e6a8 | |
| author | Dmitry Kobets <89153909+dmitrykobets-msft@users.noreply.github.com> | |
| Mon, 11 Sep 2023 17:06:40 +0000 (11 10:06 -0700) | ||
| committer | GitHub <noreply@github.com> | |
| Mon, 11 Sep 2023 17:06:40 +0000 (11 10:06 -0700) | ||
| tree | d7705dea6385250315197f9663e9fa4c4f4cd08e | treesnapshot (tar.gz zip) |
| parent | 9695da9b38471b4f3b5619763d72afcde5b4ae4d | commitdiff |
Suppress some noisy / buggy warnings (#1136)
Two warnings were being emitted in the MSVC+LLVM tests.
The warning `-Wunsafe-buffer-usage` is initially introduced in some capacity here https://reviews.llvm.org/D137346 pointing to documentation at https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734. The warning is a stylistic checker whose goal is to "emit a warning every time an unsafe operation is performed on a raw pointer". This type of programming model is not useful for library implementations of types such as `span`, where direct manipulation of raw pointers is inevitable, so disable the warning altogether.
There is also a false-positive warning https://github.com/llvm/llvm-project/issues/65689 that I've disabled inline.
Two warnings were being emitted in the MSVC+LLVM tests.
The warning `-Wunsafe-buffer-usage` is initially introduced in some capacity here https://reviews.llvm.org/D137346 pointing to documentation at https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734. The warning is a stylistic checker whose goal is to "emit a warning every time an unsafe operation is performed on a raw pointer". This type of programming model is not useful for library implementations of types such as `span`, where direct manipulation of raw pointers is inevitable, so disable the warning altogether.
There is also a false-positive warning https://github.com/llvm/llvm-project/issues/65689 that I've disabled inline.
| include/gsl/span | diffblobblamehistory | |
| tests/CMakeLists.txt | diffblobblamehistory |